[log] config/config_stdin: add debug logging to helper functions#7239
Merged
Conversation
Add logStdin.Printf calls to three previously unlogged functions: - assignLegacyIntAlias: log when a deprecated snake_case alias (connect_timeout/tool_timeout) is applied, helping identify configs that should migrate to camelCase equivalents - stripExtensionFieldsForValidation: log server count processed when stripping gateway-specific extension fields before schema validation - convertStdinServerConfig (HTTP branch): log when custom connectTimeout or toolTimeout are configured on an HTTP server Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional DEBUG=config:config_stdin instrumentation in internal/config/config_stdin.go to make stdin config conversion/validation behavior more observable during troubleshooting.
Changes:
- Log when deprecated snake_case timeout aliases are applied (
connect_timeout,tool_timeout). - Log how many servers were processed while stripping gateway-only extension fields prior to schema validation.
- Log when an HTTP server has custom connect/tool timeouts configured.
Show a summary per file
| File | Description |
|---|---|
| internal/config/config_stdin.go | Adds debug logging in stdin config parsing helpers to improve traceability of legacy aliases, validation preprocessing, and timeout configuration. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
logStdin.Printfcalls to three previously unlogged functions ininternal/config/config_stdin.go.Changes
assignLegacyIntAliasLog when a deprecated snake_case alias (
connect_timeout/tool_timeout) is applied. This surfaces configs that should migrate to the camelCase equivalents (connectTimeout/toolTimeout) — visible viaDEBUG=config:config_stdin.stripExtensionFieldsForValidationLog the server count when stripping gateway-specific extension fields (
guard,auth,tool_response_filters) before schema validation. Helpful for tracing the validation pipeline.convertStdinServerConfig(HTTP branch)Log when custom
connectTimeoutortoolTimeoutare configured on an HTTP server, making non-default timeout configuration visible during debugging.Validation
go build— compiles cleanlygo test ./...— all 26 Go packages passgofmt— no formatting changes neededFile modified
internal/config/config_stdin.go(7 lines added, 0 deleted)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.